Added integer rounding for guessed recon dimensions#645
Merged
Conversation
Member
|
Looks good to me, running tests now. Thank you very much for your contribution! |
Member
|
Ok, there was a problem with the docs, that i fixed in #646. Testing again (don't mind the buildkite fail). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #645 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 57 57
Lines 3228 3228
=======================================
Hits 2910 2910
Misses 318 318
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
|
Fix should be available in KomaMRIFiles 0.9.7! Thanks! fcf1a37 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pull request to fix #644. With this change, I am able to successfully perform reconstruction for the spiral.seq file attached to that issue.